-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fetching Reddit user posts #124142
base: dev
Are you sure you want to change the base?
Allow fetching Reddit user posts #124142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer allow integrations to add or change a platform YAML configuration.
More information on this can be found in Architecture Decision Record:
Please note that this integration connects to a device or service and another Architecture Decision Record applies that disallows the use of YAML configuration in favor of a configuration flow via the UI:
See our developer documentation on how to get started creating a configuration flow for this integration:
https://developers.home-assistant.io/docs/config_entries_config_flow_handler
As these changes often involve a bit of work and some significant shift in the current code, we will close this PR for now.
We (and our community!) would really appreciate it if you could start on the refactoring of this integration in a new PR.
Thanks already! 👍
@joostlek I'll work on a separate PR that adds a config flow and hopefully have it opened by the end of this week. |
Let me know if you need any help :) |
A bit caught up with other obligations at the moment. The config flow is complete but I need to finish the unit tests. |
Awesome! |
I switched the dependency the integration uses from |
Async sounds awesome. Can we migrate the current integration to be async before we add the flow? Otherwise the PR scope gets too big |
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: